fix syntax warnings from newer versions of Docker #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Newer versions of Docker warn about the "SDK" and "TOKEN" arguments. Pass an argument to skip these checks while documenting why it's safe to do so. Signed-off-by: Ben Cressey <bcressey@amazon.com>
bcressey
force-pushed
the
buildkit-build-checks
branch
from
0be69a4 to
be2328c
Compare
cbgbt
approved these changes
Jan 13, 2025
|
Thanks! Sorry to have missed this, I haven't seen these messages on the systems I've been testing on. |
sumukhballal
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #436
Description of changes:
Align case for
FROMandAS, and suppress checks that don't apply.Testing done:
Verified that the warnings are no longer logged.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.